src: more crypto cleanup #35509
Closed
src: more crypto cleanup #35509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
|
Review requested:
|
addaleax
approved these changes
Oct 5, 2020
Trott
approved these changes
Oct 6, 2020
|
Added |
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
more-crypto-cleanup
branch
from
e4ff8bf
to
ce5c6c9
Compare
jasnell
added
request-ci
github-actions
bot
removed
the
request-ci
jasnell
added
crypto
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasnell
added
the
author ready
jasnell
added a commit
that referenced
this pull request
Oct 13, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #35509 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell
added a commit
that referenced
this pull request
Oct 13, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #35509 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
as this builds on a semver-major commit I've added the dont-land label for older release lines |
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#35509 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#35509 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #35093 which must land first.
Continued/ongoing cleanup of crypto internals. This one factoring out toLocalChecked usage.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes